Repository navigation
[PWGLF] New code for pT vs multiplicity correlation study - #14351
Merged
Merged
Conversation
abmodak
requested review from
alibuild,
gbencedi,
mpuccio and
skundu692
as code owners
December 25, 2025 21:46
|
O2 linter results: ❌ 1 errors, |
github-actions
Bot
changed the title
vkucera
reviewed
Jan 8, 2026
Comment on lines
+30
to
+39
| #include "CCDB/BasicCCDBManager.h" | ||
| #include "CommonConstants/MathConstants.h" | ||
| #include "Framework/ASoAHelpers.h" | ||
| #include "Framework/AnalysisDataModel.h" | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/Configurable.h" | ||
| #include "Framework/O2DatabasePDGPlugin.h" | ||
| #include "Framework/runDataProcessing.h" | ||
| #include "ReconstructionDataFormats/GlobalTrackID.h" | ||
| #include "ReconstructionDataFormats/Track.h" |
vkucera
reviewed
Jan 8, 2026
Comment on lines
+65
to
+69
| kTrackTypebegin = 0, | ||
| kGlobalplusITS = 1, | ||
| kGlobalonly, | ||
| kITSonly, | ||
| kTrackTypeend |
Collaborator
There was a problem hiding this comment.
The prefix k is useless and violates naming conventions.
vkucera
reviewed
Jan 8, 2026
Comment on lines
+129
to
+130
| auto static constexpr KminCharge = 3.f; | ||
| auto static constexpr KminPtCut = 0.1f; |
Collaborator
There was a problem hiding this comment.
What is the meaning of the K prefix?
sigurdnese
pushed a commit
to sigurdnese/O2Physics
that referenced
this pull request
Jan 9, 2026
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
karlazertova
pushed a commit
to karlazertova/O2Physics
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.